Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alb_zone_id of some missing regions #137

Merged
merged 7 commits into from
Mar 1, 2021
Merged

Update alb_zone_id of some missing regions #137

merged 7 commits into from
Mar 1, 2021

Conversation

cereme
Copy link
Contributor

@cereme cereme commented Aug 28, 2020

what

  • Append alb_zone_id map for missing regions.

why

references

  • closes #136

@cereme cereme requested a review from a team as a code owner August 28, 2020 06:45
@cereme cereme requested review from joe-niland and RothAndrew and removed request for a team August 28, 2020 06:45
@cereme
Copy link
Contributor Author

cereme commented Aug 31, 2020 •
edited
Loading

As I pushed some code unrelated to this PR, I force-pushed.Please don't mind it

@AhmedNourJamalElDin
Copy link

AhmedNourJamalElDin commented Sep 23, 2020 •
edited
Loading

Merge please.
And thanks for making this map a variable 😊 .

@cereme cereme mentioned this pull request Nov 9, 2020
Closed
@blokaly
Copy link

blokaly commented Dec 10, 2020

Please can you get this merged in? Need the missing mappings. Thanks.

@cereme
Copy link
Contributor Author

cereme commented Dec 15, 2020

Resolved conflict with master(cc92c16)
Please review and merge this! 🙏

@SweetOps SweetOps added the patch A minor, backward compatible change label Mar 1, 2021
@SweetOps
Copy link
Contributor

SweetOps commented Mar 1, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2021

Command update: success

Branch has been successfully updated

@mergify mergify bot requested review from a team as code owners March 1, 2021 21:01
@SweetOps
Copy link
Contributor

SweetOps commented Mar 1, 2021

/test all

@SweetOps SweetOps merged commit 8c08826 into cloudposse:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cereme @AhmedNourJamalElDin @blokaly @SweetOps @cloudpossebot