Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Kinesis Firehose Support #1359

Merged
merged 56 commits into from
Aug 12, 2022
Merged

feat: Kinesis Firehose Support #1359

merged 56 commits into from
Aug 12, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Aug 1, 2022 •
edited
Loading

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays linked an issue Aug 1, 2022 that may be closed by this pull request
AWS::KinesisFirehose::DeliveryStream #1314
Closed
@bbernays bbernays changed the title Kinesis Firehose Support feat: Kinesis Firehose Support Aug 1, 2022
@bbernays bbernays marked this pull request as ready for review August 5, 2022 15:28
@bbernays bbernays requested a review from a team as a code owner August 5, 2022 15:28
@bbernays bbernays requested review from candiduslynx and removed request for a team August 5, 2022 15:28
candiduslynx
candiduslynx suggested changes Aug 10, 2022
View reviewed changes
resources/services/kinesis/gen.hcl Outdated Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
resources/services/kinesis/gen.hcl Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 4324f6b into cloudquery:main Aug 12, 2022
@cq-bot cq-bot mentioned this pull request Aug 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@candiduslynx candiduslynx candiduslynx approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::KinesisFirehose::DeliveryStream
3 participants
@bbernays @hermanschaaf @candiduslynx