This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
fix: create new retryer configuration for each service #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue described in sdk docs where a global retry token bucket was being shared across all services https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/retries-timeouts/#customizing-behavior
yevgenypats
suggested changes
Mar 12, 2021
provider/provider.go
Outdated
| @@ -236,7 +243,9 @@ func (p *Provider) fetchAccount(accountID string, awsCfg aws.Config, svc *sts.Cl | |||
|
|
|||
| innerLog := p.Logger.With("account_id", accountID, "region", region) | |||
| for serviceName, newFunc := range regionalServices { | |||
| resourceClients[serviceName] = newFunc(awsCfg, | |||
| cfg := awsCfg.Copy() | |||
There was a problem hiding this comment.
I think that there is no need for this line as it is already copied when awsCfg pass to this function (as it's not a pointer).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue described in sdk docs where a global retry token bucket was being shared across all services https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/retries-timeouts/#customizing-behavior
This meant that if a single service hit a backoff, then every services subsequent requests would be heavily delayed, making ingestion slow.