Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Route53 hosted zones implementation #60

Merged
merged 25 commits into from
May 17, 2021

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented May 5, 2021

No description provided.

@roneli roneli self-requested a review May 6, 2021 07:14
roneli
roneli previously approved these changes May 6, 2021
@roneli roneli dismissed their stale review May 6, 2021 07:25

Mistake

@roneli
Copy link
Contributor

roneli commented May 6, 2021

There are a few more resources in route 53 that are missing, such as Tags (ListTagsByResource), Traffic Policies, etc'

@amanenk amanenk marked this pull request as draft May 10, 2021 07:22
@amanenk amanenk marked this pull request as ready for review May 10, 2021 15:13
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was a big service. Good Job! minor comments, and a few improvement suggestions, tell me what you think.

resources/route53_delegation_sets.go Outdated Show resolved Hide resolved
resources/route53_health_checks.go Outdated Show resolved Hide resolved
resources/route53_traffic_policies.go Outdated Show resolved Hide resolved
resources/route53_traffic_policies.go Outdated Show resolved Hide resolved
resources/route53_health_checks.go Outdated Show resolved Hide resolved
resources/route53_health_checks.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
client/errors.go Outdated Show resolved Hide resolved
resources/route53_traffic_policies.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
resources/route53_helpers.go Outdated Show resolved Hide resolved
resources/route53_health_checks.go Outdated Show resolved Hide resolved
@roneli roneli mentioned this pull request May 13, 2021
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
resources/route53_hosted_zones.go Outdated Show resolved Hide resolved
@roneli roneli merged commit b79c426 into cloudquery:main May 17, 2021
@amanenk amanenk deleted the route-53-hosted-zones branch August 18, 2021 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants