fix: Don't error when field has no metadata. #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianogappa
requested review from
a team and
erezrokah
and removed request for
a team
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.33](v0.1.32...v0.1.33) (2024-08-14) ### Bug Fixes * dont error when field has no metadata. ([#221](#221)) ([aac99a9](aac99a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a PoC destination plugin in Python to prove it already supports destination plugins.
It does support them, but I encountered a small bug when processing fields with no metadata. This line errors:
plugin-sdk-python/cloudquery/sdk/schema/column.py
Line 63 in b3f898a
By simply adding an
or {}, that error is gone.I was able to implement a file destination in Python and sync XKCD into it:
$ cli sync cloudquery-config ⏱ 15:58:33 Loading spec(s) from cloudquery-config Starting sync for: xkcd (cloudquery/xkcd@v1.0.6) -> [file-python (grpc@localhost:7777)] Sync completed successfully. Resources: 2970, Errors: 0, Warnings: 0, Time: 11s