feat: Remove plugin option for logging error events to Sentry #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murarustefaan
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
murarustefaan
commented
Jun 6, 2024
| @@ -306,12 +268,7 @@ func (s *PluginServe) newCmdPluginServe() *cobra.Command { | |||
| cmd.Flags().StringVar(&otelEndpointURLPath, "otel-endpoint-urlpath", "", "Open Telemetry HTTP collector endpoint URL path") | |||
| cmd.Flags().StringArrayVar(&otelEndpointHeaders, "otel-endpoint-headers", []string{}, "Open Telemetry HTTP collector endpoint headers") | |||
| cmd.Flags().BoolVar(&otelEndpointInsecure, "otel-endpoint-insecure", false, "use Open Telemetry HTTP endpoint (for development only)") | |||
| cmd.Flags().BoolVar(&noSentry, "no-sentry", false, "disable sentry") | |||
There was a problem hiding this comment.
I'm not sure here tbh what would be the best approach, whether to remove this or have it do nothing and mark as deprecated. Wdyt?
There was a problem hiding this comment.
I would keep the option but make it deprecated and no-op.
There was a problem hiding this comment.
That makes sense, I wasn't sure if deleting it was the best decision as if it was like that, I'd have had to delete it from the other plugin sdks as well.
There was a problem hiding this comment.
Yeah I think if we remove the flag new plugins might not work with older CLI versions (don't remember if we're doing strict parsing)
candiduslynx
approved these changes
Jun 10, 2024
erezrokah
approved these changes
Jun 11, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
🤖 I have created a release *beep* *boop* --- ## [4.45.0](v4.44.2...v4.45.0) (2024-06-14) ### Features * Remove plugin option for logging error events to Sentry ([#1724](#1724)) ([7732fe8](7732fe8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.19 ([#1726](#1726)) ([a1dd044](a1dd044)) * Don't include other relation siblings if not specified in config ([#1720](#1720)) ([f730ec5](f730ec5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1809.