-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
===========================================
- Coverage 64.21% 49.79% -14.43%
===========================================
Files 32 36 +4
Lines 1280 1677 +397
===========================================
+ Hits 822 835 +13
- Misses 342 724 +382
- Partials 116 118 +2
Continue to review full report at Codecov.
|
Note: didn't remove shopping cart from the TCK, so that it still works with the currently published latest TCK, and because it looks like it's included in the docs. |
Cool! Thanks @pvlugter for the changes and fixes. For the passivation timeout I have a branch ready for that I wanted to until the reorganisation and passivation stable. |
Looks good to me |
@pvlugter Is setting the persistenceId temporarily or do we mandate that to be set implicit or by the user function on registration explicit in the future? We might have to document it too. |
I think this should be temporary, and the proxy updated to use the service name automatically for the key prefix. I'm not actually sure why persistence ids are required from the language support for any of the entities — seems that the service name could always be used, including for event sourced entities. And that it would be good to also support and include an entity version or similar. |
Update to the latest TCK from cloudstateio/cloudstate#500
I've already published a new
cloudstate-go-tck
docker image with these changes, and which should work for both the current latest TCK as well as the updated TCK in cloudstateio/cloudstate#500New TCK uncovered some small bugs:
persistenceId
, which is currently used in the proxy as a prefix for CRDT keys. The proxy could use theserviceName
directly itself, but it currently uses thepersistenceId
so I've updated here to pass the full service name as the persistence id for CRDT entities. This was uncovered when forwarding to the second entity type but with the same entity key.The passivation timeout is still to be supported, and those are the only pending tests now. I've added commented out service descriptions for these to the updated protobufs (commented out because the TCK checks that there are the same number of entities and gRPC services on entity discovery).