Emr configurations values: also allow AWS helper functions #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions are allowed by cloudformation
… functions are allowed by cloudformation
|
Thanks! |
amosshapira
pushed a commit
to amosshapira/troposphere
that referenced
this pull request
Oct 24, 2016
…s#516) * Added parameter to dynamically choose between spot and on-demand instances * Fixed EMR configuration properties validator: both strings and helper functions are allowed by cloudformation * Prevent lines with more than 79 characters to make Travis CI happy * Fixed EMR configuration properties validator: both strings and helper functions are allowed by cloudformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current master branch contains a too strict EMR configurations validator method: this validator forces configuration values to be strings. CloudFormation also allows helper functions (which allow you to use for instance a parameter value as configuration value instead of a direct string value).
This branch contains an updated validator method and updated EMR cluster example using an indirect configuration value.
I also updated the EMR example with a parameter dependent choice between spot instances or on-demand instances (using a 'condition').
The EMR example is successfully created in my AWS region eu-west-1.