Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-1707] generate TEMPORARILY_LOCKED event when max login failures are exceeded #131

Merged
merged 3 commits into from
Oct 18, 2019
Merged

[CLOUDTRUST-1707] generate TEMPORARILY_LOCKED event when max login failures are exceeded #131

merged 3 commits into from
Oct 18, 2019

Conversation

bsoniam
Copy link
Contributor

@bsoniam bsoniam commented Oct 16, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1248

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.548%
Totals Coverage Status
Change from base Build 1244: 0.01%
Covered Lines: 3011
Relevant Lines: 3289
💛 - Coveralls

fperot74
fperot74 requested changes Oct 17, 2019
View reviewed changes
pkg/event/component_test.go
}

var m = eventToMap(event)
assert.Equal(t, "TEMPORARILY_LOCKED", m[database.CtEventType])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test with a different error and one with a missing error (to ensure that f["error"] is not failing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion;
The missing error would correspond to TestEventToMapLogonError
I will add the one with diff error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests to check coverage: I think the different error is already check

@harture harture merged commit bd042c6 into master Oct 18, 2019
@fperot74 fperot74 deleted the jira-1707 branch October 29, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harture harture harture approved these changes

@fperot74 fperot74 fperot74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bsoniam @coveralls @harture @fperot74