Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-2320] Use default value for admin conf. Validation enhancements #195

Merged
merged 1 commit into from
Mar 11, 2020
Merged

[CLOUDTRUST-2320] Use default value for admin conf. Validation enhancements #195

merged 1 commit into from
Mar 11, 2020

Conversation

fperot74
Copy link
Contributor

@fperot74 fperot74 commented Mar 6, 2020 •
edited
Loading

@fperot74 fperot74 requested review from harture and bsoniam March 6, 2020 13:38
@fperot74 fperot74 changed the title [CLOUDTRUST-2320] Use default value for admin conf. Validation enhanc… [CLOUDTRUST-2320] Use default value for admin conf. Validation enhancements Mar 6, 2020
@coveralls
Copy link

coveralls commented Mar 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1939

  • 41 of 43 (95.35%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.85%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/management/component.go 1 3 33.33%
Totals Coverage Status
Change from base Build 1926: 0.006%
Covered Lines: 5207
Relevant Lines: 5669
💛 - Coveralls

@fperot74 fperot74 force-pushed the ct-2320 branch 4 times, most recently from b114c96 to 0697721 Compare March 9, 2020 09:34
@fratt-elca fratt-elca self-requested a review March 9, 2020 15:33
fratt-elca
fratt-elca approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@fratt-elca fratt-elca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

harture
harture reviewed Mar 10, 2020
View reviewed changes
api/management/api.go Outdated Show resolved Hide resolved
api/management/api.go Outdated Show resolved Hide resolved
api/management/api.go Outdated Show resolved Hide resolved
@fperot74 fperot74 force-pushed the ct-2320 branch 2 times, most recently from 4b682b4 to a2b0fef Compare March 11, 2020 11:29
@fperot74 fperot74 merged commit e6e3484 into cloudtrust:master Mar 11, 2020
@fperot74 fperot74 deleted the ct-2320 branch March 11, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harture harture harture left review comments

@bsoniam bsoniam bsoniam approved these changes

@fratt-elca fratt-elca fratt-elca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fperot74 @coveralls @harture @bsoniam @fratt-elca