gohan_raw_http: string response body type #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you rebase with master? |
Type []byte is converted to array of numbers in otto, which results in obfuscated logs, requires manual conversion to String type in order to work with response body and is generally a bad idea. In this commit, Gohan automatically converts arrived data to string and adds missing documentation for gohan_raw_http.
|
@nati , rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type []byte is converted to array of numbers in otto, which results
in obfuscated logs, requires manual conversion to String type
in order to work with response body and is generally a bad idea.
In this commit, Gohan automatically converts arrived data to string
and adds missing documentation for gohan_raw_http.