Fix issue when we got 401 from etcd #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
In case of index cleared error shouldn't there be a diff between sync and db state versions to run extensions for resources with changed state version (but not for other resources)? |
|
I believe we can't ensure anything in case of index cleared error because we may face |
Closes: issue #30 Etcd can hold up to 1000 history, so we need to handle this case correctly. We have following issues. (1) We should clone env for each extension run by sync (2) sync.Watch API keep blocking even if we get 401. (3) Stop lock per resource In case we have more than 1000 resources, sync process do infinite loop because it increases etcd index by lock. (4) sync packages is using thread-unsafe map In this commit, we fix these issues, and we added simple integration test configuraion file.
nati
added a commit
that referenced
this pull request
Nov 13, 2015
Fix issue when we got 401 from etcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: issue #30
Etcd can hold up to 1000 history, so we need to handle this case
correctly.
We have following issues.
(1) We should clone env for each extension run by sync
(2) sync.Watch API keep blocking even if we get 401.
(3) Stop lock per resource
In case we have more than 1000 resources, sync process do infinite
loop because it increases etcd index by lock.
In this commit, we fix these issues, and we added simple integration
test configuraion file.