Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: use mcache to replace bytebufferpool #1030

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feature: use mcache to replace bytebufferpool #1030

wants to merge 1 commit into from

Conversation

784909593
Copy link

@784909593 784909593 requested review from a team as code owners December 16, 2023 14:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mac seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@784909593 784909593 force-pushed the fix/repsonse_big_body_bug branch 2 times, most recently from c723e47 to 9076f70 Compare December 17, 2023 01:28
@784909593 784909593 changed the title feat: bytebuferpoll use mcache replace feat: bytebufferpool use mcache replace Dec 17, 2023
@784909593 784909593 changed the title feat: bytebufferpool use mcache replace feature: use mcache to replace bytebufferpool Dec 17, 2023
welkeyever
welkeyever reviewed Dec 27, 2023
View reviewed changes
pkg/protocol/response.go
func (resp *Response) SetBodyString(body string) {
resp.CloseBodyStream() //nolint:errcheck
resp.BodyBuffer().SetString(body) //nolint:errcheck
func (resp *Response) SetBodyString(body, url string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break change is forbidden in v1 regular iteration.

@welkeyever
Copy link
Member

  1. Please follow the template to fill the PR description.
  2. Fix CIs.
  3. Sign the CLA.

Please check that the changes are all ready for CR🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welkeyever welkeyever welkeyever left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@784909593 @CLAassistant @welkeyever