Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade sonic to v0.12.0 to be compatible with Go 1.23 #1167

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Aug 5, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

closes #1146

(Optional) The PR that updates user documentation:

@haoxins haoxins requested review from a team as code owners August 5, 2024 12:36
@haoxins
Copy link
Contributor Author

haoxins commented Aug 5, 2024

I tested it using Go 1.23.rc with my own service and it works fine.

@welkeyever welkeyever merged commit 226f0e8 into cloudwego:develop Aug 8, 2024
16 checks passed
@haoxins haoxins deleted the sonic branch August 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Go 1.23 due to locking down linkname using
3 participants