Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payload check crc32c when using ttheader #1260

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Feb 23, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ppzqh ppzqh requested review from a team as code owners February 23, 2024 10:35
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch 4 times, most recently from d574386 to a8c31c8 Compare February 23, 2024 10:50
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch from a8c31c8 to 5236e4f Compare March 11, 2024 09:52
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 70.28%. Comparing base (92f64b0) to head (e6ecd8c).

Files Patch % Lines
pkg/remote/codec/default_codec.go 79.74% 8 Missing and 8 partials ⚠️
pkg/remote/trans/netpoll/bytebuf.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1260      +/-   ##
===========================================
+ Coverage    70.21%   70.28%   +0.07%     
===========================================
  Files          287      287              
  Lines        20744    20837      +93     
===========================================
+ Hits         14565    14646      +81     
  Misses        4978     4978              
- Partials      1201     1213      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppzqh ppzqh changed the title [WIP] feat: payload check crc32c when using ttheader feat: payload check crc32c when using ttheader Mar 12, 2024
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch 2 times, most recently from 7a5743f to 05d29fd Compare March 12, 2024 03:30
pkg/remote/bytebuf.go Outdated Show resolved Hide resolved
jayantxie
jayantxie previously approved these changes Mar 12, 2024
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch from a8cd436 to 73bedf0 Compare March 12, 2024 06:49
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch from acfb00c to e134f0d Compare March 13, 2024 12:30
felix021
felix021 previously approved these changes Mar 13, 2024
@ppzqh ppzqh force-pushed the feat/payload_check_crc32c branch from e134f0d to 47406c2 Compare March 13, 2024 12:33
jayantxie
jayantxie previously approved these changes Mar 13, 2024
@ppzqh ppzqh merged commit 8c6242b into cloudwego:develop Mar 14, 2024
22 checks passed
ppzqh added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants