Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): compatible with lossless conversion for int8-64 #1287

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

wisdomearth
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

泛化调用无损兼容 int8,int16,int32,int64间相互转换

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Previously, conversion from int32 to int8 and int16 was supported, but lossless conversion between ints was not fully supported.
zh(optional): 之前支持了 int32到int8,int16 的转换,但int之间的无损转换没有完全支持

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@wisdomearth wisdomearth requested review from a team as code owners March 11, 2024 04:35
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (890b56a) to head (9f9f8c2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1287      +/-   ##
===========================================
+ Coverage    70.14%   70.31%   +0.16%     
===========================================
  Files          286      286              
  Lines        20676    20723      +47     
===========================================
+ Hits         14503    14571      +68     
+ Misses        4968     4947      -21     
  Partials      1205     1205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marina-Sakai Marina-Sakai merged commit 114e667 into cloudwego:develop Mar 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants