Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: protect filling from panic if connection closed #141

Merged
merged 2 commits into from
May 5, 2022
Merged

fix: protect filling from panic if connection closed #141

merged 2 commits into from
May 5, 2022

Conversation

joway
Copy link
Member

@joway joway commented May 5, 2022

Fixes: #140

Hchenn
Hchenn reviewed May 5, 2022
View reviewed changes
connection_impl.go Outdated Show resolved Hide resolved
@joway joway merged commit 82dfcad into cloudwego:develop May 5, 2022
@joway joway deleted the fix/close-and-read branch May 5, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hchenn Hchenn Hchenn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: panic if close the connection when it blocking on conn.Read
2 participants
@joway @Hchenn