Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(volo-http): refactor context and service for server #354

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

yukiiiteru
Copy link
Member

@yukiiiteru yukiiiteru commented Feb 7, 2024

This PR is for server side.

  1. Remove state fully. FromContext and FromRequest do not need generic type S now
  2. Remove Parts from ServerContext
  3. Update args of from_context from (&mut ServerContext, &State) to (&mut ServerContext, &mut Parts)
  4. Update args of from_context from (&mut ServerContext, ServerRequest, State) to (&mut ServerContext, Parts, Incoming)
  5. Update all service from Service<ServerContext, Incoming> to Service<ServerContext, ServerRequest>
  6. Rename DynService to Route

This PR also updates volo-http to 0.2.0-rc1

@yukiiiteru yukiiiteru mentioned this pull request Feb 7, 2024
15 tasks
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@yukiiiteru yukiiiteru marked this pull request as ready for review February 18, 2024 03:08
@yukiiiteru yukiiiteru requested review from a team as code owners February 18, 2024 03:08
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@yukiiiteru yukiiiteru merged commit 3eac9c7 into cloudwego:main Feb 18, 2024
13 checks passed
@yukiiiteru yukiiiteru deleted the chore/server-context-refactor branch February 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants