feat(volo-http): use generic types for resp and err #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous code uses a fixed Service with
Response = ServerResponse
andError = Infallible
, which is not flexible enough.Solution
This PR updates
Service
s for server. ItsResponse
can be of any type withIntoResponse
, andError
can be any type withouttrait
. The only restriction is that theError
must be converted toServerResponse
(withError = Infallible
) before it is given to the client.In other words, you can define your own error code in the business code, but you must handle it before sending it to client.
An example is also updated where you can create a service with an error code (
usize
in the example, which doesn't implementIntoResponse
) and wrap it with a layer to convert it.