feat(volo-http): support default target for client #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds default target address for client. In addition, this commit also adds `Target` with its builder. With them introduced, client and request builder can use a more elegant method for setting target address. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we use HTTP client for a fixed target address, this PR adds default target for client, with which client can build a request without setting the target address and send it directly.
In addition, this PR also adds
Targetwith its builder. With them introduced, client and request builder can use a more elegant way for setting target address.Solution
ClientBuilderTargetBuilderwhich can be set to address or hostname and will be resolved to address finally