Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid classifying K8S002 on zero-replica workloads #51

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: Avoid classifying K8S002 on zero-replica workloads #51

merged 1 commit into from
Nov 28, 2023

Conversation

agurgel-te
Copy link
Contributor

By definition, a workload with no pods can't be disrupted by an upgrade.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice the Apache-2.0 license.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

By definition, a workload with no pods can't be disrupted by an upgrade.
@bryantbiggs bryantbiggs changed the title Don't fire K8S002 on zero-replica workloads fix: Avoid classifying K8S002 on zero-replica workloads Nov 28, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thank you!

@bryantbiggs bryantbiggs merged commit b63f12c into clowdhaus:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants