Issue #7, do not convert index into reflections hash using :to_s #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declaration.name.to_s does not work as the reflections hash requires a symbol
sponomarev
reviewed
Sep 2, 2019
There was a problem hiding this comment.
Thanks for your contribution! Can you cover your case mentioned in #40 with specs?
|
If I understand the problem correctly, we must add a new gemfile to Travis marix (e.g. gemfiles/activerecord41.gemfile) and without current patch CI should fail. |
|
Hi @vanboom ! I was trying to add AR-4.1 to CI and my experiment showed that it is did not run without troubles :( |
|
Ok - I will see what I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaration.name.to_s does not work as the reflections hash requires a symbol