Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Suggestion] in dark mode #1538

Closed
bibsp opened this issue Feb 9, 2022 · 5 comments
Closed

[Bug/Suggestion] in dark mode #1538

bibsp opened this issue Feb 9, 2022 · 5 comments

Comments

@bibsp
Copy link

bibsp commented Feb 9, 2022

When I hover mouse pointer over top menu bar the options are getting highlighted in light mode.
But in dark mode it does not.
In dark mode the options get highlighted only when I actually click on them to expand.

This is a very little thing which you can fix I think.
1
2
3

@adipose
Copy link

adipose commented Feb 12, 2022

#1547

@clsid2 clsid2 closed this as completed Feb 12, 2022
@xLn2
Copy link

xLn2 commented Mar 6, 2022

Additionally, menu text color always same whether its top most level or bottom level.

resim
_
resim
in example at second picture, menu text color might be grayish like title text as been.

@adipose
Copy link

adipose commented Mar 29, 2022

#1630

It now fades the menu text a bit when the window is not in the foreground. Note that in Windows Explorer (the inspiration for this theme), it does not fade it, but it also has a toolbar based menu which is dissimilar to MPC-HC's menu style. But I think this looks a bit better.

@xLn2
Copy link

xLn2 commented Mar 30, 2022

Thanks, It looks nice.
resim

I noticed after you mentioned. that windows explorer file menu does not fade out (during bottom state) or getting highlighted on mouse hover but instead when I drag mouse on any file or folder it gets highlighted. I can only guess, that is intended behavior for windows that clickable things get highlighted. So i think that everything is clickable in mpc-hc during bottom state so I think its match with windows dark theme somehow. Thanks again for your efforts.

@bibsp
Copy link
Author

bibsp commented Apr 2, 2022

Still one small detail mismatched.
When window is not in foreground Dark and Light theme behavior is different.

Untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants