Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by supporting new default loop #22

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

clue
Copy link
Owner

@clue clue commented Jul 21, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$es = new Clue\React\EventSource\EventSource('https://example.com/stream.php', $loop);

// new (using default loop)
$es = new Clue\React\EventSource\EventSource('https://example.com/stream.php');

Builds on top of reactphp/event-loop#226, reactphp/event-loop#232 and reactphp/http#410

@clue clue added the new feature New feature or request label Jul 21, 2021
@clue clue added this to the v1.0.0 milestone Jul 21, 2021
@clue clue merged commit d5a88ba into clue:master Jul 21, 2021
@clue clue deleted the default-loop branch July 21, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant