Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify examples by updating to new default loop #24

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Simplify examples by updating to new default loop #24

merged 1 commit into from
Jul 16, 2021

Conversation

PaulRotmann
Copy link
Contributor

@PaulRotmann PaulRotmann commented Jul 14, 2021 •
edited
Loading

This changeset simplifies usage by supporting the new default loop.
Builds on top of reactphp/event-loop#232, reactphp/stream#159, reactphp/http#410

@clue clue added the new feature New feature or request label Jul 16, 2021
@clue clue changed the title Simplify usage by supporting new default loop Simplify examples by updating to new default loop Jul 16, 2021
clue
clue approved these changes Jul 16, 2021
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulRotmann Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v1.4.0 milestone Jul 16, 2021
@clue clue merged commit a37a12b into clue:master Jul 16, 2021
@yadaiio yadaiio mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulRotmann @clue