-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with resource files in fat jar #759
Comments
As a minor side-issue, note how in the logging message in the case I was running this from the reach repo folder, it says
so the line count is not shown as intended. |
At runtime (except maybe during testing, so testtime), nothing should refer to the directory structure of the source code. So, I think you've found a problem. I'm looking into what to do about it. |
Thank you Keith!
…On Tue, Aug 24, 2021 at 8:14 AM Keith Alcock ***@***.***> wrote:
At runtime (except maybe during testing, so testtime), nothing should
refer to the directory structure of the source code. So, I think you've
found a problem. I'm looking into what to do about it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#759 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI75TWQS4ZW2GHZ3QNSPMDT6OZL5ANCNFSM5CV344AA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
The logging statement does have a bug as well, but it is readily fixed. |
This is being addressed with #760. |
Thank you! I have now been using this and everything seems to work. |
I am trying to create a fat JAR of the latest Reach using
sbt assembly
and then using it to process text with the ApiRuler's annotate_text method (this has been our standard integration approach, no change here). If I do this exactly from the Reach repo's main folder, it works, i.e. it is able to load all the resource files and return a resultHowever, if I move to any other folder, loading the resource files fails when attempting to load the first resource file:
-> process exits here.
So I suspect the issue is with the path by which the bioresources are referred to in the context of a JAR file.
In particular, I am wondering if this line: https://github.com/clulab/reach/blob/master/bioresources/src/main/resources/application.conf#L1 could be responsible for the issue.
Any help would be appreciated!
The text was updated successfully, but these errors were encountered: