Anafora Reader #25
Closed
Anafora Reader #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethard
requested changes
Aug 4, 2017
| @@ -42,6 +43,26 @@ class Entity(xml: Elem) extends Annotation(xml) { | |||
| def text(implicit data: Data): String = spans.map{ | |||
| case (start, end) => data.text.substring(start, end) | |||
| }.mkString("...") | |||
| private def recursiveSpan(entity: Entity, start: Int, end: Int)(implicit data:Data): (Int, Int) = { | |||
There was a problem hiding this comment.
These changes don't seem to belong in this pull request; as far as I can tell, AnaforaReader doesn't use any of these methods.
|
|
||
| class AnaforaReader(dct: SimpleInterval)(implicit data: Data) { | ||
|
|
||
| val DCT = dct |
There was a problem hiding this comment.
Just declare it as AnaforaReader(val DCT: SimpleInterval) if you want a publicly accessible DCT.
| @@ -1042,5 +1042,12 @@ class TypesTest extends FunSuite with TypesSuite { | |||
| NthFromStartRIs(Year(1997), 1, RepeatingUnit(ChronoUnit.MONTHS), 9) | |||
| === SimpleIntervals((1 to 9).map(m => SimpleInterval.of(1997, m)))) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This doesn't seem relevant to the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.