Optional text input files #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethard
requested changes
Aug 8, 2017
| XML.fromSource(io.Source.fromFile(xmlPath)), | ||
| io.Source.fromFile(textPath).mkString) | ||
| def apply(xml: Elem, text: String) = new Data(xml, text) | ||
| def fromPaths(xmlPath: String, textPath: Option[String]) =textPath match { |
There was a problem hiding this comment.
I believe this could be more concisely written as:
apply(XML.fromSource(io.Source.fromFile(xmlPath)), textPath.map(p => io.Source.fromFile(p).mkString)
| def text(implicit data: Data): String = spans.map{ | ||
| case (start, end) => data.text.substring(start, end) | ||
| }.mkString("...") | ||
| def text(implicit data: Data): Option[String] = data.text match { |
There was a problem hiding this comment.
I believe this could be more concisely written as:
data.text.map(text => spans.map {
case (start, end) => text.substring(start, end)
}.mkString("..."))
| @@ -26,7 +26,7 @@ case class FractionalNumber(number: Int, numerator: Int, denominator: Int) exten | |||
| val isDefined = true | |||
| } | |||
|
|
|||
| case class VagueNumber(description: String) extends Number { | |||
| case class VagueNumber(description: Option[String]) extends Number { | |||
There was a problem hiding this comment.
Don't make VagueNumber take an Option[String]. Rather, in your scorer where the value of the VagueNumber doesn't matter, just pass some meaningless value. Something like entity.text.getOrElse("").
There was a problem hiding this comment.
Ok. Should I do the same with Event and TimeZone?
|
Yes, that's right.
On Aug 8, 2017 09:47, EgoLaparra <notifications@github.com> wrote:
@EgoLaparra commented on this pull request.
________________________________
In src/main/scala/info/bethard/timenorm/formal/Types.scala<#28 (comment)>:
@@ -26,7 +26,7 @@ case class FractionalNumber(number: Int, numerator: Int, denominator: Int) exten
val isDefined = true
}
…-case class VagueNumber(description: String) extends Number {
+case class VagueNumber(description: Option[String]) extends Number {
Ok. Should I do the same with Event and TimeZone?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#28 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABERhwKxdb4VGzKs7DqefU2bmPzZlwL0ks5sWJE8gaJpZM4Ow96R>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.