Overhauls score method, simplifying implementation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually overlaps with multiple intervals
* allIntervalsFrom function added to TimeNormScorer. Checking Start-Included and End-Included in Between type * allIntervalsFrom function added to TimeNormScorer. Checking Start-Included and End-Included in Between type * Start-Included and End-Included conversion to boolean * startIncluded and endIncluded are false by default in Between type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered committing this directly, but the tests for the scorer are sparse, so even though I believe they're all passing, I think it would be safer for @EgoLaparra to try it out on real data and confirm that the scores are identical to the previous version.