New BetweenInclusive class in Types #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethard
requested changes
Sep 29, 2017
| @@ -136,7 +136,10 @@ class AnaforaReader(val DCT: Interval)(implicit data: Data) { | |||
| case ("Two-Digit-Year", Some(value), N, N, N, None) => value.partition(_ != '?') match { | |||
| case (year, questionMarks) => YearSuffix(interval(properties), year.toInt, questionMarks.length) | |||
| } | |||
| case ("Between", None, N, N, N, None) => Between(interval(properties, "Start-"), interval(properties, "End-")) | |||
| case ("Between", None, N, N, N, None) => interval(properties, "Start-").end == interval(properties, "End-").start match { | |||
There was a problem hiding this comment.
You need to instead be checking the "Start-Included" and "End-Included" properties.
| * @param startInterval first interval | ||
| * @param endInterval second interval | ||
| */ | ||
| case class BetweenInclusive(startInterval: Interval, endInterval: Interval) extends Interval { |
There was a problem hiding this comment.
I think we may need to add extra parameters to Between rather than adding a new class. See the comment above: the start and end can independently be set as inclusive or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.