Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete backwards the annotation starting from (start - 1) character #44

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Complete backwards the annotation starting from (start - 1) character #44

merged 2 commits into from
Jul 25, 2019

Conversation

EgoLaparra
Copy link
Contributor

Iterator.from(start, -1) starts with the start character, so .takeWhile(doExpand) returns empty because start is not "O".

@EgoLaparra EgoLaparra requested a review from bethard July 25, 2019 01:17
@EgoLaparra EgoLaparra mentioned this pull request Jul 25, 2019
Open
@bethard
Copy link
Collaborator

bethard commented Jul 25, 2019

This looks like a correct fix, but please also add a test like https://github.com/clulab/timenorm/blob/master/src/test/scala/org/clulab/timenorm/neural/TemporalNeuralParserTest.scala#L97 where the test fails before you apply your fix, and passes afterwards.

@EgoLaparra EgoLaparra merged commit b478afd into master Jul 25, 2019
@bethard bethard deleted the fix-in-completing-annotation branch August 8, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethard bethard bethard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgoLaparra @bethard