SimplePeriod tests and implementation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
awmarkley
commented
Feb 24, 2016
awmarkley
commented
- Added getValue method to IntNumber
| case class IntNumber(n: Int) extends Number | ||
| case class IntNumber(n: Int) extends Number { | ||
|
|
||
| def getValue( ): Int = { return n } |
There was a problem hiding this comment.
For your current implementation, you don't need this method, so leave it out for now. We should discuss if there's a common method that all Number subclasses should support.
awmarkley
force-pushed
the
simple-period
branch
from
2001afe
to
6dd0ee8
Compare
bethard
added a commit
that referenced
this pull request
Feb 26, 2016
SimplePeriod tests and implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.