Small things 4 #379
Merged
Small things 4 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the regex for detecting startup to also work with 0.16 as updateTick was called mapTick before 0.17. Note: This commit does not imply 0.16 is going to be supported by Cluestio.
Remove log rotation as Factorio implemented its own log rotation an eternety ago and the cluster log already contains all the log entries.
The Node.js specific rules for Eslint were deprecated in favour of the node plugin for Eslint. Add node plugin for eslint and switch over to using its rules, fixing any issues detected.
Create equipment grid for items that support it and doesn't currently have a grid. Fixes deserialization of spidertron equipment grids.
Ignore files instead checking if the entry is a directory looking for modules to patch in. This is to support symbolic link to modules.
Add missing levels import from the logging library in ControlConnection.js.
The plugins are available as a property on the Control provided by the ControlContext which makes the PluginsContext redundant. Remove it and use ControlContext to retreive the plugin list in the app.
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
===========================================
+ Coverage 32.06% 79.17% +47.10%
===========================================
Files 18 59 +41
Lines 1029 5137 +4108
===========================================
+ Hits 330 4067 +3737
- Misses 699 1070 +371
Continue to review full report at Codecov.
|
psihius
reviewed
May 17, 2021
psihius
approved these changes
May 17, 2021
|
Merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes an improvement that doesn't make sense to put into separate PRs: