Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/0.7] add featureGate IgnoreLeaseSync to stop sync leases.coordination.k8s.io #621

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Dec 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

cherry-pick #615

This pr adds a featureGate IgnoreLeaseSync to stop synchronizing internal resources that the majority of users do not care about. Currently only leases.coordination.k8s.io is added since it updates too frequently.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a featureGate `SkipSyncLeases` to stop synchronizing `leases.coordination.k8s.io`

@27149chen 27149chen changed the title cherry-pick 615 [release/0.7] add featureGate IgnoreLeaseSync to stop sync leases.coordination.k8s.io Dec 20, 2023
@clusterpedia-bot
Copy link

Hi @27149chen,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

Signed-off-by: lou <alex1988@outlook.com>
(cherry picked from commit b6eeea8)
Signed-off-by: lou <alex1988@outlook.com>
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This pr has a relatively small impact on the overall logic, but it is a valuable feature that can be cherry-picked into the latest release(release/0.7).

@Iceber Iceber merged commit 002486a into clusterpedia-io:release/0.7 Dec 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants