Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High resolution photos #22

Merged
merged 2 commits into from
Feb 4, 2020
Merged

High resolution photos #22

merged 2 commits into from
Feb 4, 2020

Conversation

litso
Copy link
Member

@litso litso commented Feb 4, 2020

Attempts to improve camera photos by requesting higher resolution photographs, following Apple's example code.

Pivotal Tracker tickets

https://www.pivotaltracker.com/story/show/170479462

@litso litso requested a review from u2606 February 4, 2020 01:51
u2606
u2606 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@u2606 u2606 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Does enabling high-resolution capture improve photo quality? I didn’t think we were having a problem with resolution. Our apps already reduce the size of photos returned by TiltUp before uploading them.

@litso litso merged commit e2a3c91 into master Feb 4, 2020
@litso litso deleted the high-resolution-photos branch February 4, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u2606 u2606 u2606 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litso @u2606