Notch updates #55
Merged
Notch updates #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use safeAreaInsets when possible, otherwise update frames manually.
litso
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
(Sorry for the delay in reviewing, usually we try to turn around a pr in less than 2 days)
Nice cleanup Alex, just one comment.
@jbrophy17 can show you how to release a new version of TiltUp when you are ready.
| @@ -245,7 +245,7 @@ final class CameraOverlayView: UIView { | |||
| return outerStackView | |||
| }() | |||
|
|
|||
| private lazy var previewImageView: UIImageView = { | |||
| public lazy var previewImageView: UIImageView = { | |||
There was a problem hiding this comment.
Yes, its now used to set the previewView frame in the CameraController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeAreaInsetswhere possible.Pivotal Tracker tickets
(link to all relevant Pivotal Tracker tickets)
Screenshots
(if the changes are visual, provide screenshots with brief descriptions)