Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields in ICE candidates #13

Closed
ibc opened this issue Jan 14, 2014 · 3 comments
Closed

Missing fields in ICE candidates #13

ibc opened this issue Jan 14, 2014 · 3 comments

Comments

@ibc
Copy link
Collaborator

ibc commented Jan 14, 2014

Original ICE candidates generated by Chrome 31:

a=candidate:1162875081 1 udp 2113937151 192.168.34.75 60808 typ host generation 0
a=candidate:1162875081 2 udp 2113937151 192.168.34.75 60808 typ host generation 0
a=candidate:3289912957 1 udp 1845501695 XXX.84.77.194 60808 typ srflx raddr 192.168.34.75 rport 60808 generation 0
a=candidate:3289912957 2 udp 1845501695 XXX.84.77.194 60808 typ srflx raddr 192.168.34.75 rport 60808 generation 0
a=candidate:198437945 1 tcp 1509957375 192.168.34.75 0 typ host generation 0
a=candidate:198437945 2 tcp 1509957375 192.168.34.75 0 typ host generation 0

Candidates when calling "write" in sdp-transform:

a=candidate:1162875081 1 udp 2113937151 192.168.34.75 60808 typ host
a=candidate:1162875081 2 udp 2113937151 192.168.34.75 60808 typ host
a=candidate:3289912957 1 udp 1845501695 XXX.84.77.194 60808 typ srflx
a=candidate:3289912957 2 udp 1845501695 XXX.84.77.194 60808 typ srflx
a=candidate:198437945 1 tcp 1509957375 192.168.34.75 0 typ host
a=candidate:198437945 2 tcp 1509957375 192.168.34.75 0 typ host

sdp-transform ignores some fields. Those fields are optional but... why to ignore them?

@clux
Copy link
Owner

clux commented Jan 14, 2014

No good reason, they should be there. Thanks for the issue.

@clux
Copy link
Owner

clux commented Jan 14, 2014

Ah the reason is the same as for #12. Conditional syntax wasn't handled well by the writer. Will be fixed in the next version.

@ibc
Copy link
Collaborator Author

ibc commented Jan 18, 2014

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants