Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fontawesome plugin for TinyMCE 5 #35

Closed
wants to merge 2 commits into from

Conversation

manu37
Copy link
Contributor

@manu37 manu37 commented Jan 20, 2019

editors/tinymce5: directory added and /fontawesome/plugin.min.js plugineditor.windowManager.open() calls modified

editor.windowManager.open() calls modified
@cmb69
Copy link
Owner

cmb69 commented Jan 22, 2019

Thanks! Did you use fontawesome/plugin.min.js which is shipped with Fa_XH 1.2/CMSimple_XH 1.7.2 as base? Next time better use fontawesome/plugin.min.js from the sources.

Anyhow, there are issues with FA icons inserted in headings (and maybe other places as well) – I cannot delete these anymore. :?

PS: Regarding deleting icons: there are general issues in Chrome (IE 11 and FF work); backspace doesn't delete the icon, but rather acts like left arrow key; delete key works, but not if the icon is at the start or the end of a block level element.

addButton method added
@cmb69 cmb69 added this to the 1.3 milestone Jan 30, 2021
@cmb69 cmb69 changed the title add tinymce5 Add fontawesome plugin for TinyMCE 5 Mar 14, 2021
@cmb69
Copy link
Owner

cmb69 commented Mar 14, 2021

The problems with deleting the icons in Chrome (can still reproduce this with latest version) are not particularly related to Font Awesome or the plugin, but rather a general issue with empty spans; sad, but it is like it is. So I'm going to merge the PR with the tweaks mentioned above.

@cmb69 cmb69 closed this in f82a3ce Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants