error: fix deprecated usage of sys_errlist #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array sys_errlist is marked as deprecated in recent versions of glibc. The code already attempted to use strerror_r but it was not being used because of missing include of config.h. But the unused code to use strerror_r had another issue because there are two versions of strerror_r in glibc. Use the defined feature test macro (man strerror_r) to handle both versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array sys_errlist is marked as deprecated in recent versions
of glibc. The code already attempted to use strerror_r but it
was not being used because of missing include of config.h.
But the unused code to use strerror_r had another issue because
there are two versions of strerror_r in glibc. Use the defined
feature test macro (man strerror_r) to handle both versions.