Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save mapping and init from mapping #14

Merged
merged 12 commits into from
May 14, 2021

Conversation

jennyfothergill
Copy link
Member

@jennyfothergill jennyfothergill commented May 11, 2021

Summary:

  • add save_mapping function (this required changing the mapping keys to be json serializable (not tuple))

  • allow a CG_Compound to be initialized from bead specification or a mapping

  • add allow_overlap to decide if ring structures share atoms

  • add unit tests

fixes #11 fixes #12

this required changing the mapping keys to be json serializeable (no tuple)
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #14 (682d18e) into master (341a53b) will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   96.90%   97.70%   +0.79%     
==========================================
  Files           4        4              
  Lines         194      218      +24     
==========================================
+ Hits          188      213      +25     
+ Misses          6        5       -1     
Impacted Files Coverage Δ
grits/coarsegrain.py 96.15% <100.00%> (+1.09%) ⬆️
grits/finegrain.py 98.38% <100.00%> (+1.66%) ⬆️

@chrisjonesBSU
Copy link
Member

Giving this a try right now. I did get this error message after running pip install -e . in the repo.

Collecting openbabel
  Downloading openbabel-3.1.1.1.tar.gz (82 kB)
ERROR: Could not find a version that satisfies the requirement rdkit (from grits) (from versions: none)
ERROR: No matching distribution found for rdkit

@jennyfothergill jennyfothergill merged commit 4d5c018 into cmelab:master May 14, 2021
@jennyfothergill jennyfothergill deleted the feat/savemapping branch May 14, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a mapping save and load from mapping functions mappings to ring structures should not always share atoms
2 participants