-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save mapping and init from mapping #14
Merged
jennyfothergill
merged 12 commits into
cmelab:master
from
jennyfothergill:feat/savemapping
May 14, 2021
Merged
Save mapping and init from mapping #14
jennyfothergill
merged 12 commits into
cmelab:master
from
jennyfothergill:feat/savemapping
May 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this required changing the mapping keys to be json serializeable (no tuple)
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 96.90% 97.70% +0.79%
==========================================
Files 4 4
Lines 194 218 +24
==========================================
+ Hits 188 213 +25
+ Misses 6 5 -1
|
Giving this a try right now. I did get this error message after running
|
chrisjonesBSU
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
add save_mapping function (this required changing the mapping keys to be json serializable (not tuple))
allow a CG_Compound to be initialized from bead specification or a mapping
add allow_overlap to decide if ring structures share atoms
add unit tests
fixes #11 fixes #12