-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly set the mass when creating mb.Compound from a Snapshot; add mass_scale
parameter
#49
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 96.62% 96.64% +0.01%
==========================================
Files 4 4
Lines 385 387 +2
==========================================
+ Hits 372 374 +2
Misses 13 13
|
It looks like we are getting the SMARTS strings wrong in this test, or borking the search somewhere. Running on the p3ht.gsd included in the repo gives this warning: ==============================
*** Open Babel Warning in PerceiveBondOrders
Failed to kekulize aromatic bonds in OBMol::PerceiveBondOrders (title is Compound)
/Users/cmelab/repos/grits/grits/coarsegrain.py:139: UserWarning: c1cscc1 not found in compound!
warn(f"{smart_str} not found in compound!")
/Users/cmelab/repos/grits/grits/coarsegrain.py:139: UserWarning: CCC not found in compound!
warn(f"{smart_str} not found in compound!")``` |
Looks like it might be openbabel version updates causing the hiccup |
This was happening because of us removing hydrogens erroneously before invoking grits, and without using the proper flag in the |
Merging this for now since it is needed for #51 , we'll address the failing unit tests after this overhaul in finished up. |
I was getting some errors when trying to create a CG trajecotry of PPS. Ultimately, I think the errors resulted from a change in how mass is handled in mBuild. This PR sets the particle mass from the snapshot particle mass, and includes a
mass_scale
parameter for converting from reduced mass to real mass (similar to what was being done with length)