Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] Please stay tuned with this thread. #3

Open
eastskykang opened this issue Mar 18, 2021 · 3 comments
Open

[Announcement] Please stay tuned with this thread. #3

eastskykang opened this issue Mar 18, 2021 · 3 comments
Assignees

Comments

@eastskykang
Copy link
Contributor

eastskykang commented Mar 18, 2021

At the moment, github action (which checks unit tests) fails. But this doesn't affect carrying out your assignment. Just please check if the unit test passes by running the test manually.

I will fix this issue as soon as possible.

@eastskykang eastskykang changed the title [Announcement] Github action fails [Announcement] We are not going to github action. Please check test by yourself. Mar 22, 2021
@eastskykang
Copy link
Contributor Author

eastskykang commented Mar 22, 2021

Update:

Realized our library is dependent on GUI thus it's not possible to use github action (it requires pretty a lot of code modification to enable this)

We are not going to use github action. Please check the test yourself by running test-a2. For evaluation, we are going to download all the repositories and run the test one-by-one.

Note. Let me be clear. Passing the test does not mean you get full point from Ex.4. The evaluation of the assignments will be based on your demo video, code and test all together.

Evaluation criteria is not discussable.

@eastskykang eastskykang changed the title [Announcement] We are not going to github action. Please check test by yourself. [Announcement] We are not going to use github action. Please check test by yourself. Mar 22, 2021
@eastskykang eastskykang changed the title [Announcement] We are not going to use github action. Please check test by yourself. [Announcement] GitHub action, test typo etc. Mar 25, 2021
@eastskykang
Copy link
Contributor Author

eastskykang commented Mar 25, 2021

IMPORTANT: There was a typo in test-a2. Please correct it yourself and run the test for ex.4.

See this for more detilas: #21

@eastskykang eastskykang changed the title [Announcement] GitHub action, test typo etc. [Announcement] GitHub action, test typo etc. Please stay tuned with this thread. Mar 25, 2021
@eastskykang eastskykang self-assigned this Mar 25, 2021
@eastskykang eastskykang changed the title [Announcement] GitHub action, test typo etc. Please stay tuned with this thread. [Announcement] Please stay tuned with this thread. Mar 25, 2021
@eastskykang eastskykang changed the title [Announcement] Please stay tuned with this thread. [Announcement] IMPORTANT: Please stay tuned with this thread. Mar 25, 2021
@eastskykang eastskykang changed the title [Announcement] IMPORTANT: Please stay tuned with this thread. [Announcement] Please stay tuned with this thread. Mar 25, 2021
@eastskykang
Copy link
Contributor Author

Please see #33 and fix your code, if your code includes such eigen matrix overwriting. This can cause some problem in certain systems (and compilers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant