app routes: catch loader errors in meta function

remix-run/remix#3140
cmnord · Mar 31, 2023 · c1aacf6 · c1aacf6
1 parent 8051aa3
commit c1aacf6
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 9 deletions.
diff --git a/app/routes/$gameId.solo.tsx b/app/routes/$gameId.solo.tsx
@@ -8,9 +8,15 @@ import { getGame } from "~/models/game.server";
 import { getOrCreateUserSession } from "~/session.server";
 import { getRandomName } from "~/utils/name";
 
-export const meta: MetaFunction<typeof loader> = ({ data }) => ({
-  title: data.game.title,
-});
+export const meta: MetaFunction<typeof loader> = ({ data }) => {
+  try {
+    return {
+      title: data.game.title,
+    };
+  } catch (error: unknown) {
+    return {};
+  }
+};
 
 export async function loader({ request, params }: LoaderArgs) {
   const gameId = params.gameId;

diff --git a/app/routes/mock.tsx b/app/routes/mock.tsx
@@ -6,9 +6,15 @@ import GameComponent from "~/components/game";
 import { GameEngineContext, useSoloGameEngine } from "~/engine";
 import { getMockGame } from "~/models/mock.server";
 
-export const meta: MetaFunction<typeof loader> = ({ data }) => ({
-  title: data.game.title,
-});
+export const meta: MetaFunction<typeof loader> = ({ data }) => {
+  try {
+    return {
+      title: data.game.title,
+    };
+  } catch (error: unknown) {
+    return {};
+  }
+};
 
 export async function loader() {
   const game = await getMockGame();

diff --git a/app/routes/room.$roomName.tsx b/app/routes/room.$roomName.tsx
@@ -12,9 +12,15 @@ import { getRoom } from "~/models/room.server";
 import { getOrCreateUserSession } from "~/session.server";
 import { getRandomName } from "~/utils/name";
 
-export const meta: MetaFunction<typeof loader> = ({ data }) => ({
-  title: data.game.title,
-});
+export const meta: MetaFunction<typeof loader> = ({ data }) => {
+  try {
+    return {
+      title: data.game.title,
+    };
+  } catch (error: unknown) {
+    return {};
+  }
+};
 
 export async function loader({ request, params }: LoaderArgs) {
   const roomName = params.roomName;