Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the muon SF for UL and tag names for Jet Resolution in 2016 UL #1293

Conversation

emanueledimarco
Copy link
Contributor

  • muon SFs are for 2016 vs abs(eta)
  • fix typo in the tag names for 2016 preVFP and post VFP JR

@youyingli
Copy link
Contributor

To remove the eta extension part should be suitable as we have taken the absolute value to muon eta.

@emanueledimarco
Copy link
Contributor Author

Yes this is what I did I think in the last commit 38c7368, no?

@youyingli
Copy link
Contributor

youyingli commented Oct 25, 2022

Sorry for the late review. Your modification could still create some useless negative-eta bins as the muon now take the absolute value. You should remove L92-L99, L123-L130, L139-L146, L156-L163, L198 and modify L101 back to
pt_bins[ pt_from ] = self.binInfo.bins[-1]
and L165-L166 back to
pt_bins[ sorted(pt_bins.keys())[-1] ].upBounds[1] = float( 'inf' ).

@JunquanTao
Copy link
Contributor

Hi Youying @youyingli , I have also sumitted a PR severals ago and do some changes on the file "flashggMuonSystematics_cfi.py". Please review it. Thanks, Junquan
[1] #1295

@emanueledimarco
Copy link
Contributor Author

@youyingli thanks, I didn't notice those pieces. Should be removed now.

@youyingli
Copy link
Contributor

@emanueledimarco thanks. Merged!

@youyingli youyingli merged commit eb32c14 into cms-analysis:dev_legacy_runII Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants