This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
[hotfix] Adapt exception class for const correctness #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When migrating functionality in
cmsgemos
, catching the exceptions raised byxhal
by const reference was breakingconst
-correctness semantics.The implemented
what()
inxhal
was notconst
, as it is in thestd::exception
class it inherits from.Types of changes
Motivation and Context
How Has This Been Tested?
I tested that
ctp7_modules
still compiles (but it doesn't care about much fromxhal
), otherwise, I am not sure what else might be affected by this. (I would say nothing should be, as this change just enforces a contract that was probably already made).