Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

[hotfix] Adapt exception class for const correctness #101

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

jsturdy
Copy link
Contributor

@jsturdy jsturdy commented Jan 11, 2019

Description

When migrating functionality in cmsgemos, catching the exceptions raised by xhal by const reference was breaking const-correctness semantics.
The implemented what() in xhal was not const, as it is in the std::exception class it inherits from.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

How Has This Been Tested?

I tested that ctp7_modules still compiles (but it doesn't care about much from xhal), otherwise, I am not sure what else might be affected by this. (I would say nothing should be, as this change just enforces a contract that was probably already made).

@mexanick mexanick merged commit 9b2f8a1 into develop Mar 4, 2019
@jsturdy jsturdy deleted the hotfix/fix-exceptions branch March 2, 2020 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants