Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Adding get_binaries.py and ipbus to the list of uploads #9

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

mexanick
Copy link
Contributor

@mexanick mexanick commented Sep 4, 2017

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Adding script for convenient retrieval of binaries (in fact all the uploads)

How Has This Been Tested?

Tested by downloading libraries from v2.0.0 release

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. -- NOT YET --> will be done after the merge and forming a new release.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mexanick
Copy link
Contributor Author

mexanick commented Sep 4, 2017

@jsturdy, please review and approuve as soon as you can, since this is a blocking merge before I can create a new release and update the documentation, which has been already requested.

Copy link
Contributor

@jsturdy jsturdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@jsturdy jsturdy merged commit b7f1812 into cms-gem-daq-project:master Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants