feat: add DeepJet inputs #39

AnnikaStein · 2021-12-04T00:15:02Z

Add custom producer to get information for 25 cpfs, 25 npfs and 4 SVs (similar to JetConstituentTableProducer), but store these in the already existing Jet table (flat, no new collections) - if requested via add_DeepJet and keep_inputs
Include full output nodes for DeepJet (if requested via add_DeepJet) - I guess Keep full output nodes for DeepCSV and DeepJet #35 is related
Second new option add_DeepJet_noclip, which adds more variables on top of add_DeepJet: uses raw quantities without any preprocessing by catch_infs_and_bound (variables are not clipped / scaled)

AnnikaStein · 2021-12-12T16:36:54Z

Access DeepJet inputs via TagInfoCollection in a new, custom producer, similar to JetConstituentTableProducer.cc, but using the logic of DeepFlavourONNXJetTagsProducer.cc
No more recalculation of features necessary (but could of course revert to the old way and compare - my personal checks showed they are in good agreement) - see this notebook for details (and scroll all the way down, I'm sorry)
Minor clean up in other files

Note: size and descriptions for 5000 events when DeepJet inputs (and output probabilities) are added. (Cf. old size and descriptions from recalculating variables. See also the same number of events, without DeepJet here: size and description.)

andrzejnovak · 2021-12-20T09:39:11Z

python/addBTV.py

@@ -6,7 +6,7 @@
 from PhysicsTools.PatAlgos.tools.helpers import addToProcessAndTask, getPatAlgosToolsTask


-def update_jets_AK4(process):
+def update_jets_AK4(process, add_DeepJet):


I would shuffle to logic around a bit here. Have the DeepCSV/DeepJet output nodes in as the default (~10 branches anyway) and keep the DeepCSV/DeepJet inputs as toggles

Good idea. And would you prefer one individual toggle per type of tagger or use only the keepInputs toggle for enabling all tagger inputs at the same time? Don't know if there are use cases where one only needs e.g. DeepCSV but not DeepJet, or DDX...

I am thinking as we move on we might want to be dropping DeepCSV, also not all studies will need all taggers. I think my preference would be passing a list with up to ['DeepCSV', 'DeepJet', 'DDX'] and pattern match it after, but having it as 3 bools is not that bad either

Ok, so that would make 2^3=8 possible combinations to be added in pfnano_cff.py for each MC or Data configuration, right?

In case you go with bools, I'd say it's not necessary that all combinations are part of the cff, can be added as/if needed

andrzejnovak · 2021-12-20T09:40:04Z

python/addBTV.py

+                          float,
+                          doc="DeepJet gluon tag probability",
+                          precision=10),
+        # anstein: could add discriminators here (or just leave it as it is, only output nodes with individual probabilities)


I would add the discriminators, it's just 3 branches anyway, B, Cvl, CvB

Just saw that these discriminators are already included via nano (declared inside jets_cff.py):

'Jet_btagDeepFlavB', 'Jet_btagDeepFlavC', # this one only until 106x 'Jet_btagDeepFlavCvB', 'Jet_btagDeepFlavCvL', 'Jet_btagDeepFlavQG',

So I can probably keep it as it is? (btagDeepFlavC will be duplicated, depending on the era (<= 106x), discriminators are always in, not dependent on the era, individual probabilities I add manually, not dependent on the era)

See
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jets_cff.py#L233-L239
for the discriminators

and
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jets_cff.py#L268
for btagDeepFlavC

👍 indeed, in fact if you could check there aren't any duplicate branches in the current output fill overall that would be great

def duplicates(mykeys): seen = set() for x in mykeys: if x in seen: print(x) seen.add(x) return duplicates(keys)

used for the configuration PFnano_customizeMC_add_DeepJet gives me this output

FatJet_btagDDBvLV2 FatJet_btagDDCvBV2 FatJet_btagDDCvLV2 Jet_btagDeepFlavC FatJet_nBHadrons FatJet_nCHadrons SubJet_nBHadrons SubJet_nCHadrons

Jet_btagDeepFlavC was expected, as explained above, the others are not related to what I added or modified in this PR I guess.

andrzejnovak · 2021-12-20T09:41:40Z

plugins/DeepJetTableProducer.cc

+  const edm::EDGetTokenT<TagInfoCollection> tag_info_src_;
+  // anstein: could be used later to manually change number of features and constituents per feature
+  /*
+  constexpr static unsigned n_features_global_ = 15;


Looks better to use these, than to hardcode the number later on in each entry

andrzejnovak · 2021-12-20T09:44:10Z

plugins/DeepJetTableProducer.cc

+
+
+      // ============================================================== Cpfs ===================================================================
+      input_name = "DeepJet_Cpfcan_puppiw_" + s;


Maybe these can be formated better? Defining and overwriting description and inpu_name for each entry is redundant

…leanup

andrzejnovak

Alright, looks good to me. I left a couple of comments, mostly to clean up commented out code, but then we can merge

andrzejnovak · 2021-12-21T22:51:42Z

plugins/DeepJetTableProducer.cc

+
+  edm::EDGetTokenT<edm::View<T>> jet_token_;
+
+  // anstein: from ONNX producer


Suggested change

// anstein: from ONNX producer

andrzejnovak · 2021-12-21T22:52:27Z

plugins/DeepJetTableProducer.cc

+  typedef std::vector<reco::DeepFlavourTagInfo> TagInfoCollection;
+  const edm::EDGetTokenT<TagInfoCollection> tag_info_src_;
+
+  // anstein: number of constituents will be used, number of features per constituent not necessary


Suggested change

// anstein: number of constituents will be used, number of features per constituent not necessary

can remove commented out stuff here

andrzejnovak · 2021-12-21T22:55:39Z

plugins/DeepJetTableProducer.cc

+  for (unsigned int p = 0; p < n_cpf_; p++) {
+      auto s = std::to_string(p);
+
+      djTable->addColumn<float>("DeepJet_Cpfcan_puppiw_" + s, Cpfcan_puppiw_nCpf[p], "charged candidate PUPPI weight of the " + s + ". cpf", nanoaod::FlatTable::FloatColumn, 10);


Suggested change

djTable->addColumn<float>("DeepJet_Cpfcan_puppiw_" + s, Cpfcan_puppiw_nCpf[p], "charged candidate PUPPI weight of the " + s + ". cpf", nanoaod::FlatTable::FloatColumn, 10);

djTable->addColumn<float>("DeepJet_Cpfcan_puppiw_" + s,

Cpfcan_puppiw_nCpf[p],

"charged candidate PUPPI weight of the " + s + ". cpf",

nanoaod::FlatTable::FloatColumn, 10);

can we format like this?

yes we can! :) will change all affected lines and split them to improve readability.

andrzejnovak · 2021-12-21T22:56:31Z

plugins/DeepJetTableProducer.cc

+      djTable->addColumn<float>("DeepJet_sv_d3dsig_" + s, sv_d3dsig_nSV[p], "3D impact parameter (flight distance) significance of the " + s + ". SV", nanoaod::FlatTable::FloatColumn, 10);
+      djTable->addColumn<float>("DeepJet_sv_costhetasvpv_" + s, sv_costhetasvpv_nSV[p], "cosine of the angle between the " + s + ". SV flight direction and the direction of the " + s + ". SV momentum", nanoaod::FlatTable::FloatColumn, 10);
+      /*
+      // anstein: only relevant if also included in the tag info, not yet, maybe in future versions of the tagger


keep these, as they might be relevant later, but as a rule most comments could/should be removed

AnnikaStein · 2021-12-22T11:53:58Z

All requested changes should be in now, but as I'm only Author, not Collaborator, I think someone else has to merge this PR.

AnnikaStein added 8 commits November 28, 2021 20:18

Feature: adding DeepJet inputs, clip / noclip

52b9578

Minor updates

3270e67

Add WIP code (just for reference)

7cfe13e

Add DeepJet inputs, clean

d1988b1

clean / revert minor changes

96c3f57

add / remove / reword comments

1f9d50f

delete outdated, commented-out code

8d1c450

Get DeepJet inputs via TagInfoCollection

6225d31

Remove unused columns in custom producer

8c0e36a

andrzejnovak reviewed Dec 20, 2021

View reviewed changes

feat: specify which tagger inputs will be stored (list of strings), c…

4bf74dd

…leanup

andrzejnovak reviewed Dec 21, 2021

View reviewed changes

AnnikaStein added 2 commits December 22, 2021 01:04

style: improve formatting

ec8e738

style: improve formatting

8b5b69c

andrzejnovak changed the title ~~Add DeepJet inputs~~ feat: add DeepJet inputs Dec 22, 2021

andrzejnovak merged commit bbb8657 into cms-jet:master Dec 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add DeepJet inputs #39

feat: add DeepJet inputs #39

AnnikaStein commented Dec 4, 2021

AnnikaStein commented Dec 12, 2021 •

edited

Loading

andrzejnovak Dec 20, 2021

AnnikaStein Dec 20, 2021

andrzejnovak Dec 20, 2021

AnnikaStein Dec 20, 2021

andrzejnovak Dec 20, 2021

andrzejnovak Dec 20, 2021

AnnikaStein Dec 20, 2021

andrzejnovak Dec 20, 2021

AnnikaStein Dec 20, 2021

andrzejnovak Dec 20, 2021

andrzejnovak Dec 20, 2021

andrzejnovak left a comment

andrzejnovak Dec 21, 2021

andrzejnovak Dec 21, 2021

andrzejnovak Dec 21, 2021

andrzejnovak Dec 21, 2021

andrzejnovak Dec 21, 2021

AnnikaStein Dec 21, 2021

andrzejnovak Dec 21, 2021

AnnikaStein commented Dec 22, 2021



		// ============================================================== Cpfs ===================================================================
		input_name = "DeepJet_Cpfcan_puppiw_" + s;


		edm::EDGetTokenT<edm::View<T>> jet_token_;

		// anstein: from ONNX producer

feat: add DeepJet inputs #39

feat: add DeepJet inputs #39

Conversation

AnnikaStein commented Dec 4, 2021

AnnikaStein commented Dec 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrzejnovak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnnikaStein commented Dec 22, 2021

AnnikaStein commented Dec 12, 2021 •

edited

Loading