Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter gen particles by status in caching #40

Closed
artlbv opened this issue Jun 27, 2023 · 5 comments
Closed

Filter gen particles by status in caching #40

artlbv opened this issue Jun 27, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@artlbv
Copy link
Collaborator

artlbv commented Jun 27, 2023

It seem we do not filter the genparticles by status when we cache them.
This creates a huge collection especially for genphotons, e.g.:

22M	cache/V29/V29_DYLL_M50_part_e.parquet
8.0M	cache/V29/V29_DYLL_M50_part_mu.parquet
269M	cache/V29/V29_Hgg_part_gamma.parquet
4.3M	cache/V29/V29_HHToTauTau_part_tau.parquet
6.7M	cache/V29/V29_VBFHToTauTau_part_tau.parquet

However, we should probably at least require status == 1 in this step, as done in the FastPuppi ntupler:
https://github.com/p2l1pfp/FastPUPPI/blob/12_5_X/NtupleProducer/python/runPerformanceNTuple.py#L339

@artlbv artlbv added enhancement New feature or request good first issue Good for newcomers labels Jun 27, 2023
@artlbv
Copy link
Collaborator Author

artlbv commented Jun 27, 2023

To be checked also viz the hadronic tau fixes by @bonanomi

@bonanomi
Copy link
Collaborator

We do have this requirement on the final state particles (in _filter_fspart_branches). This is the collection that is used to compute the isolation wrt the gen-level particles. We can introduce this mask also in _filter_genpart_branches. Although this was not done in the C++ version of the tools. We'd need to check that introducing this requirement does not change the performance (ie a full run of validation would be required if this change is introduced)

@bonanomi
Copy link
Collaborator

To be checked also viz the hadronic tau fixes by @bonanomi

For hadronic taus this additional filtering should not be required, as in that case we ask for status==2 directly (ie I am not sure it would make sense to require status == 1 AND status == 2).

@artlbv
Copy link
Collaborator Author

artlbv commented Jun 28, 2023 via email

@artlbv
Copy link
Collaborator Author

artlbv commented Mar 13, 2024

Obsolete due to move to nano

@artlbv artlbv closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants