Consolidation of Phase-2 e/g object interface #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerminar
force-pushed
the
eg_refine_interface_133x_v1
branch
from
e85678f
to
4e390f9
Compare
gpetruc
reviewed
Nov 17, 2023
| refRemapper.origRefAndPtr.push_back(std::make_pair(refEg, tkele.trkPtr())); | ||
| emu.sta_idx = refRemapper.origRefAndPtr.size() - 1; | ||
|
|
||
| // FIXME: this is hugly |
| @@ -87,15 +87,16 @@ namespace l1ct { | |||
| z0_t hwZ0; | |||
| tkdeta_t hwDEta; // relative to the region center, at calo | |||
| tkdphi_t hwDPhi; // relative to the region center, at calo | |||
| id_score_t hwIDScore; | |||
There was a problem hiding this comment.
BTW the two comments above on hwDEta and hwDPhi are misleading
…idate and cleanup TkElectron interface
…n pv-based isolation. Set charge of TkElectrons
cerminar
force-pushed
the
eg_refine_interface_133x_v1
branch
from
4e390f9
to
c71ee04
Compare
gpetruc
suggested changes
Nov 17, 2023
| if (trkPtr_.isNonnull()) { | ||
| setTrkzVtx(trkPtr()->POCA().z()); | ||
| } | ||
| } | ||
|
|
||
| TkElectron::TkElectron(const LorentzVector& p4, float tkisol) | ||
| : TkElectron(p4, edm::Ptr<L1Candidate>(nullptr, 0), edm::Ptr<L1TTTrackType>(nullptr, 0), tkisol) {} |
There was a problem hiding this comment.
Suggested change
| : TkElectron(p4, edm::Ptr<L1Candidate>(nullptr, 0), edm::Ptr<L1TTTrackType>(nullptr, 0), tkisol) {} | |
| : TkElectron(p4, edm::Ptr<L1Candidate>(), edm::Ptr<L1TTTrackType>(), tkisol) {} |
| TkEm::TkEm(const LorentzVector& p4, const edm::Ref<EGammaBxCollection>& egRef, float tkisol) | ||
| : TkEm(p4, egRef, tkisol, -999) {} | ||
| TkEm::TkEm(const LorentzVector& p4, float tkisol, float tkisolPV) | ||
| : TkEm(p4, edm::Ptr<L1Candidate>(nullptr, 0), tkisol, tkisolPV) {} |
There was a problem hiding this comment.
Suggested change
| : TkEm(p4, edm::Ptr<L1Candidate>(nullptr, 0), tkisol, tkisolPV) {} | |
| : TkEm(p4, edm::Ptr<L1Candidate>(), tkisol, tkisolPV) {} |
| } | ||
| refRemapper.origRefAndPtr.push_back(std::make_pair(refEg, edm::Ptr<RefRemapper::L1TTTrackType>(nullptr, 0))); | ||
| emu.sta_idx = refRemapper.origRefAndPtr.size() - 1; | ||
| constituentsPtrs.push_back(std::make_pair(tkem.egCaloPtr(), edm::Ptr<L1TTTrackType>(nullptr, 0))); |
There was a problem hiding this comment.
Suggested change
| constituentsPtrs.push_back(std::make_pair(tkem.egCaloPtr(), edm::Ptr<L1TTTrackType>(nullptr, 0))); | |
| constituentsPtrs.push_back(std::make_pair(tkem.egCaloPtr(), edm::Ptr<L1TTTrackType>())); |
|
PR to master is cms-sw#43317 |
aloeliger
added
the
Data types
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no files with code format issues!
|
epalencia
merged commit 3ad78a5
into
cms-l1t-offline:phase2-l1t-integration-13_3_0_pre3
|
Tagged as |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR addresses several issues with the interface of
TkElectronandTkEmobjects and the HW objects used by the Phase2 GT emulator:Egammastandalone objects since they are not the actual ancestors due to architectural choice in L1T hardware. The ref is replaced by anedm::Ptrto the calorimeter primitive (different in barrel and endcap).TkElectroninterface and of data members;TkElectrons;TkElectroncoordinates.NOTE: backward compatibility is maintained via IO rule in the reflex dictionary.
PR validation:
Successfully tested reading files produced with previous versions of the object data formats.