Onnx implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprouvost
added
documentation
riga
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Very nice!
I have two minor comments (inline) and two additional suggestions.
- There is now quite a lot of code duplication between the ONNX and TF runtime measurement plugins. Let's have the overlap organized in a common base class.
- We should also be able to load models from yaml files instead of json.
Let's chat privately on how to divide the work.
…r, add super and inheritance to object in Model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ONNX, implementation of PlotRuntimesMultipleParams instead of PlotRuntimesMultipleNetworks and PlotRuntimesMultipleCMSSW, refactoring parameters and new parameters for labels, add onnx examples and update existing tf examples, updated docu (wrong as of now in master after last refactoring)